[webkit-reviews] review granted: [Bug 57075] [Qt] QNetworkReplyHandler refactoring: signal queue : [Attachment 89234] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 12 11:53:53 PDT 2011


Andreas Kling <kling at webkit.org> has granted Luiz Agostini <luiz at webkit.org>'s
request for review:
Bug 57075: [Qt] QNetworkReplyHandler refactoring: signal queue
https://bugs.webkit.org/show_bug.cgi?id=57075

Attachment 89234: patch
https://bugs.webkit.org/attachment.cgi?id=89234&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89234&action=review

r=me. This is a great step towards making this spaghetti understandable without
spending 2 hours reading it. :)

> Source/WebCore/platform/network/qt/QNetworkReplyHandler.h:77
> +    void readyRead();

didReceiveReadyRead() or something like that would sound more slot-like.


More information about the webkit-reviews mailing list