[webkit-reviews] review requested: [Bug 57954] [Qt] Height of "Ahem" font differs from all other ports. : [Attachment 89231] Proposed patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 12 11:31:18 PDT 2011


Andreas Kling <kling at webkit.org> has asked  for review:
Bug 57954: [Qt] Height of "Ahem" font differs from all other ports.
https://bugs.webkit.org/show_bug.cgi?id=57954

Attachment 89231: Proposed patch v2
https://bugs.webkit.org/attachment.cgi?id=89231&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
The previous patch exposed a bug on on FreeType platforms where fonts may have
negative leading which leads to situations where lineSpacing < (ascent +
descent.) Applied the same workaround as SimpleFontDataFreeType to cover this
case.


More information about the webkit-reviews mailing list