[webkit-reviews] review granted: [Bug 58348] commit-queue should upload failure diffs when tests fail : [Attachment 89226] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 58348: commit-queue should upload failure diffs when tests fail
https://bugs.webkit.org/show_bug.cgi?id=58348

Attachment 89226: Patch
https://bugs.webkit.org/attachment.cgi?id=89226&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89226&action=review

> Tools/Scripts/webkitpy/tool/commands/queues.py:-54
> -

We probably should keep this line, right?

> Tools/Scripts/webkitpy/tool/commands/queues.py:263
> +	   bot_id = self._tool.status_server.bot_id or "bot"

self.name instead of "bot" ?

> Tools/Scripts/webkitpy/tool/commands/queues.py:270
> +	   comment_text = "The attached test failures were seen while running
run-webkit-tests on the %s.\n" % (self.name)

No () needed.