[webkit-reviews] review granted: [Bug 56906] CSS related SVG*Element changes doesn't require relayout : [Attachment 89193] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 12 10:31:20 PDT 2011


Nikolas Zimmermann <zimmermann at kde.org> has granted Renata Hodovan
<reni at webkit.org>'s request for review:
Bug 56906: CSS related SVG*Element changes doesn't require relayout
https://bugs.webkit.org/show_bug.cgi?id=56906

Attachment 89193: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=89193&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89193&action=review

Very nice, please do this before landing:

> Source/WebCore/rendering/svg/RenderSVGResourceFilterPrimitive.cpp:44
> +

How about moving the hasTagName check right here, after the base class call.
Then use early return style.


More information about the webkit-reviews mailing list