[webkit-reviews] review granted: [Bug 58324] Web Inspector: remove scriptWorldType from the protocol. : [Attachment 89212] [PATCH] that compiles.

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 58324: Web Inspector: remove scriptWorldType from the protocol.
https://bugs.webkit.org/show_bug.cgi?id=58324

Attachment 89212: [PATCH] that compiles.
https://bugs.webkit.org/attachment.cgi?id=89212&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89212&action=review

> Source/WebCore/bindings/js/ScriptDebugServer.cpp:247
> +    return true;

return (currentWorld(exec) != mainThreadNormalWorld()); ?

> Source/WebCore/bindings/v8/DebuggerScript.js:80
> +	   isContentScript: script.context_data &&
script.context_data.indexOf("injected") == 0

Please cast the expression to boolean explicitly to avoid surprises when it's
an undefined and is casted ToBoolean() in ScriptDebugServer.cpp.