[webkit-reviews] review requested: [Bug 57850] [Qt][WK2] Qt port needs test content for qwkhistory : [Attachment 89216] Proposed added QTestLib content for qwkhistory

[bugzilla-daemon at webkit.org]

Jamie Cooley <james.cooley at nokia.com> has asked  for review:
Bug 57850: [Qt][WK2] Qt port needs test content for qwkhistory
https://bugs.webkit.org/show_bug.cgi?id=57850

Attachment 89216: Proposed added QTestLib content for qwkhistory
https://bugs.webkit.org/attachment.cgi?id=89216&action=review

------- Additional Comments from Jamie Cooley <james.cooley at nokia.com>
Still have these style errors, but I'm not sure I can do anything about:

<snip> tst_qwkhistory.cpp:21:  Found other header before WebCore config.h.
Should be: config.h, primary header, blank line, and then alphabetically
sorted.  [build/include_order] [4]

Isn't actually in my code or any code that I can see or have touched. Must come
from includes that include includes?

Source/WebKit2/UIProcess/API/qt/tests/qwkhistory/tst_qwkhistory.cpp:78: 
historyFBTest_data is incorrectly named. Don't use underscores in your
identifier names.  [readability/naming] [4]

This is QTestLib's data-driven test format... If I want to use data-driven
(which is a pretty useful construct for this test), you have to name it as
such.