[webkit-reviews] review granted: [Bug 58287] [chromium] WebCrossOriginRequestPolicy enum should use 'Web' prefix for values : [Attachment 89201] Proposed Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Bill Budge
<bbudge at gmail.com>'s request for review:
Bug 58287: [chromium] WebCrossOriginRequestPolicy enum should use 'Web' prefix
for values
https://bugs.webkit.org/show_bug.cgi?id=58287

Attachment 89201: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=89201&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
R=me

Since this is likely to break Chromium, what is the plan for landing this
change?

A couple ideas:

1- You could add a #define in WebURLLoader.h, and then in Chromium code you can
land #ifdefs that switch on that #define to determine which definition of
WebURLLoaderOptions and CrossOriginRequestPolicy to use.  Then, land that
Chromium patch before landing this WebKit patch.

2- You could change this WebKit patch to make WebURLLoader.h #include
WebURLLoaderOptions.h, and you could also keep the old enum around, defined in
terms of the new one.