[webkit-reviews] review denied: [Bug 58329] Web Inspector: ResourceView.createResourceView should return ResourceView instance. : [Attachment 89209] Patch.

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 58329: Web Inspector: ResourceView.createResourceView should return
ResourceView instance.
https://bugs.webkit.org/show_bug.cgi?id=58329

Attachment 89209: Patch.
https://bugs.webkit.org/attachment.cgi?id=89209&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89209&action=review

> Source/WebCore/inspector/front-end/ResourceView.js:61
> +	   this._sourceFrame.show(parentElement);

Why do we need the show / hide logic in the SourceFrame now? Can we use the
same view in the scripts panel instead?

> Source/WebCore/inspector/front-end/SourceFrame.js:42
> +    this._view = new WebInspector.View();

Why do you need this? I thought we agreed that there should be no SourceFrame
-> View dependency.