[webkit-reviews] review granted: [Bug 56659] [GTK] Expose menu items and menus as children of a menu bar : [Attachment 89015] Patch proposal + Layout test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 12 08:50:43 PDT 2011

chris fleizach <cfleizach at apple.com> has granted Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 56659: [GTK] Expose menu items and menus as children of a menu bar

Attachment 89015: Patch proposal + Layout test

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=89015&action=review

otherwise looks good. r=me

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2968
>	       return MenuItemRole;

It looks like we're calling parentObjectUnignored()->ariaRoleAttribute()
potentially three times. I think that value should be stored local.
parentObjectUnignored() can be little expensive.

More information about the webkit-reviews mailing list