[webkit-reviews] review requested: [Bug 56906] CSS related SVG*Element changes doesn't require relayout : [Attachment 89193] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 12 06:18:20 PDT 2011

Renata Hodovan <reni at webkit.org> has asked  for review:
Bug 56906: CSS related SVG*Element changes doesn't require relayout

Attachment 89193: Proposed patch

------- Additional Comments from Renata Hodovan <reni at webkit.org>
I did your recommendations, but there was still one potential bug... Since we
didn't verify that the object we got in styleDidChange was of the correct type,
it could happen that after calling setFilterEffectAttribute() on another
filter, we'd hit an ASSERT_NOT_REACHED. So I supplemented the patch with a
type-check and this way it's safe already. :)

More information about the webkit-reviews mailing list