[webkit-reviews] review denied: [Bug 56393] Without checking existence of the renderer of the element, tries to access the enclosing layer. : [Attachment 89185] Modified changelog

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 12 04:44:15 PDT 2011


Benjamin Poulain <benjamin at webkit.org> has denied suchi
<suchi.kundu at nokia.com>'s request for review:
Bug 56393: Without checking existence of the renderer of the element,tries to
access the enclosing layer.
https://bugs.webkit.org/show_bug.cgi?id=56393

Attachment 89185: Modified changelog
https://bugs.webkit.org/attachment.cgi?id=89185&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
You seem very confused about this change. First, understand what is going on,
should the layer be null here, if yes in which cases. Then make a layout test
accessing this path.

If that crashes on some websites, it is likely possible to make a test for it.


More information about the webkit-reviews mailing list