[webkit-reviews] review granted: [Bug 58240] Web Inspector: document console domain, support cross-domain type references. : [Attachment 89014] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 12 04:33:32 PDT 2011


Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 58240: Web Inspector: document console domain, support cross-domain type
references.
https://bugs.webkit.org/show_bug.cgi?id=58240

Attachment 89014: Patch
https://bugs.webkit.org/attachment.cgi?id=89014&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89014&action=review

> Source/WebCore/inspector/ConsoleMessage.cpp:114
> +    case NetworkErrorMessageType: return "networkError";

These constants need refactoring. Worth a separate change though.


More information about the webkit-reviews mailing list