[webkit-reviews] review denied: [Bug 58259] Web Inspector: Enable raw HTTP headers support : [Attachment 89064] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 58259: Web Inspector: Enable raw HTTP headers support
https://bugs.webkit.org/show_bug.cgi?id=58259

Attachment 89064: Patch
https://bugs.webkit.org/attachment.cgi?id=89064&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89064&action=review

> LayoutTests/inspector/http-headers-parser.html:9
> +InspectorTest.createHeaders = function(lines)

just declare them as "function createHeaders()" in your "function test()"

> Source/WebCore/inspector/Inspector.json:285
> +		       "rawHeaders": { "type": "string", "optional": true,
"description": "Raw HTTP response headers." },

I'd suggest renaming these to rawHttpRequest and rawHttpResponse since they
contain not only headers. It might require you to rename it in multiple places.


> Source/WebCore/inspector/front-end/Resource.js:387
> +	   if (!this._requestHeaders && this._rawRequestHeaders)

So we only use this parser when there are no requestHeaders? But I think we do
have them at all times.