[webkit-reviews] review granted: [Bug 58289] On Solaris 10 with SS12 compiler, TCMalloc_PageHeap::runScavengerThread(void* context) is expected to return a value : [Attachment 89152] patch that fixes the issues, and passes check-webkit-style locally
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Apr 11 22:04:27 PDT 2011
Alexey Proskuryakov <ap at webkit.org> has granted Ben Taylor
<bentaylor.solx86 at gmail.com>'s request for review:
Bug 58289: On Solaris 10 with SS12 compiler,
TCMalloc_PageHeap::runScavengerThread(void* context) is expected to return a
value
https://bugs.webkit.org/show_bug.cgi?id=58289
Attachment 89152: patch that fixes the issues, and passes check-webkit-style
locally
https://bugs.webkit.org/attachment.cgi?id=89152&action=review
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
Honestly, I don't understand why we don't just always have this "return 0".
+#if (COMPILER(MSVC) || COMPILER(SUNCC))
Unneeded parentheses here.
More information about the webkit-reviews
mailing list