[webkit-reviews] review denied: [Bug 58292] Provide new setting to allow site icon loading despite disabling automatic image loading in general. : [Attachment 89136] patch - fixed whitespace bot complaints

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 11 21:15:39 PDT 2011


Sam Weinig <sam at webkit.org> has denied Alice Liu <alice.liu at apple.com>'s
request for review:
Bug 58292: Provide new setting to allow site icon loading despite disabling
automatic image loading in general.
https://bugs.webkit.org/show_bug.cgi?id=58292

Attachment 89136: patch - fixed whitespace bot complaints
https://bugs.webkit.org/attachment.cgi?id=89136&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89136&action=review

> Source/WebKit/mac/WebView/WebPreferences.h:338
> +    @method setWillLoadSiteIconsIgnoringImageLoadingPreference:
> +    @param flag
> +*/
> +- (void)setLoadsSiteIconsIgnoringImageLoadingPreference: (BOOL)flag;
> +
> +/*!
> +    @method willLoadSiteIconsIgnoringImageLoadingPreference
> +*/
> +- (BOOL)loadsSiteIconsIgnoringImageLoadingPreference;

These have not gone through API review, so these need to be in
WebPreferencesPrivate.h


More information about the webkit-reviews mailing list