[webkit-reviews] review granted: [Bug 34415] [Qt] QWebPluginFactory based plugins are always painted on top, ignore z-index : [Attachment 89088] Make QtGraphicsPluginWidget AC code path friendly

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Girish Ramakrishnan
<girish at forwardbias.in>'s request for review:
Bug 34415: [Qt] QWebPluginFactory based plugins are always painted on top,
ignore z-index
https://bugs.webkit.org/show_bug.cgi?id=34415

Attachment 89088: Make QtGraphicsPluginWidget AC code path friendly
https://bugs.webkit.org/attachment.cgi?id=89088&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=89088&action=review

Looks sensible. Any manual test? :-)

> Source/WebKit/qt/ChangeLog:10
> +	   content because they were not integratede into the AC code path. The


integrated*

> Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:1442
> -class QtPluginGraphicsWidget: public Widget
> +class QtPluginGraphicsWidget: public PluginViewBase

I still think we need to move these somewhere else :/ The classes I mean, out
of FrameLoaderClient