[webkit-reviews] review canceled: [Bug 53625] svn-apply and/or patch(1) has trouble applying patches that makes changes to files with Windows line endings : [Attachment 89055] Patch and unit tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 11 13:57:50 PDT 2011


Daniel Bates <dbates at webkit.org> has canceled Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 53625: svn-apply and/or patch(1) has trouble applying patches that makes
changes to files with Windows line endings
https://bugs.webkit.org/show_bug.cgi?id=53625

Attachment 89055: Patch and unit tests
https://bugs.webkit.org/attachment.cgi?id=89055&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
Renamed parseEOL() to parseFirstEOL() as suggested by Eric Seidel.

Also, renamed fileEOL() to firstEOLInFile() in VCSUtils.pm and
parseEOLWithString() to firstEOLInString() in parseEOL.pl so as to be more
descriptive.


More information about the webkit-reviews mailing list