[webkit-reviews] review granted: [Bug 54634] media/video-controls-in-media-document.html has image+text diffs : [Attachment 89069] Use shadow DOM and avoid hardcoding controls height.

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Ami Fischman
<fischman at chromium.org>'s request for review:
Bug 54634: media/video-controls-in-media-document.html has image+text diffs
https://bugs.webkit.org/show_bug.cgi?id=54634

Attachment 89069: Use shadow DOM and avoid hardcoding controls height.
https://bugs.webkit.org/attachment.cgi?id=89069&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=89069&action=review

Thanks!

> LayoutTests/media/video-controls-in-media-document.html:14
> +    testExpected("controls.offsetTop + controls.offsetHeight",
video.offsetHeight, "<=");

Much better than what I suggested!