[webkit-reviews] review granted: [Bug 57904] onClick does not function with <select> elements in WebKit2 : [Attachment 89021] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Jon Lee <jonlee at apple.com>'s
request for review:
Bug 57904: onClick does not function with <select> elements in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=57904

Attachment 89021: Patch
https://bugs.webkit.org/attachment.cgi?id=89021&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=89021&action=review

The indentation in WebPopupMenuProxyMac.mm is messed up.

> Source/WebKit2/UIProcess/mac/WebPopupMenuProxyMac.mm:127
> +	   if (m_client)

This could be an early return.

> Source/WebKit2/UIProcess/mac/WebPopupMenuProxyMac.mm:132
> +	       NSEvent* initiatingNSEvent =
m_client->currentlyProcessedMouseDownEvent()->nativeEvent();

I think you need to null check the event before getting the native event.

> Source/WebKit2/UIProcess/win/WebPopupMenuProxyWin.cpp:328
> +    if (m_client) {

Early return.

> Source/WebKit2/UIProcess/win/WebPopupMenuProxyWin.cpp:339
> +	   const MSG* initiatingWinEvent =
m_client->currentlyProcessedMouseDownEvent()->nativeEvent();

Null check.