[webkit-reviews] review granted: [Bug 58252] WebKit2:=?UTF-8?Q?=20links=20don=E2=80=99t=20update=20to=20look=20visited=20?=: [Attachment 89043] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 58252: WebKit2: links don’t update to look visited
https://bugs.webkit.org/show_bug.cgi?id=58252

Attachment 89043: Patch
https://bugs.webkit.org/attachment.cgi?id=89043&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=89043&action=review

> Source/WebKit2/WebProcess/WebProcess.cpp:281
> +    for (size_t i = 0; i < linkHashes.size(); ++i) {
> +	   HashMap<uint64_t, RefPtr<WebPageGroupProxy> >::const_iterator it =
m_pageGroupMap.begin();
> +	   HashMap<uint64_t, RefPtr<WebPageGroupProxy> >::const_iterator end =
m_pageGroupMap.end();
> +	   for (; it != end; ++it)
> +	      
Page::visitedStateChanged(PageGroup::pageGroup(it->second->identifier()),
linkHashes[i]);
> +    }

Could you add a FIXME here specifying that we might not want to track visited
links per context but per page group?

> Source/WebKit2/WebProcess/WebProcess.cpp:289
> -    Page::allVisitedStateChanged(sharedPageGroup());
> +    HashMap<uint64_t, RefPtr<WebPageGroupProxy> >::const_iterator it =
m_pageGroupMap.begin();
> +    HashMap<uint64_t, RefPtr<WebPageGroupProxy> >::const_iterator end =
m_pageGroupMap.end();
> +    for (; it != end; ++it)
> +	  
Page::allVisitedStateChanged(PageGroup::pageGroup(it->second->identifier()));

Ditto.