[webkit-reviews] review denied: [Bug 57459] REGRESSION(r82419): extra border in t0805-c5519-ibrdr-r-00-a.html : [Attachment 88939] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 11 11:24:11 PDT 2011

Eric Seidel <eric at webkit.org> has denied Yael <yael.aharon at nokia.com>'s request
for review:
Bug 57459: REGRESSION(r82419): extra border in t0805-c5519-ibrdr-r-00-a.html

Attachment 88939: Patch.

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=88939&action=review

> Source/WebCore/rendering/InlineFlowBox.cpp:265
> +    while (parent && renderer()->containingBlock() != parent) {

renderer()->containingBlock() does a lot of work, no?  Seems we should cache

I'm also not sure I understand this part of the change.  The rest of the change
looks fine.

More information about the webkit-reviews mailing list