[webkit-reviews] review requested: [Bug 58188] [Qt] MediaPlayerPrivateQt::supportsType does not parse codec parameter : [Attachment 89030] Modified patch based on Benjamin's comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 11 10:56:56 PDT 2011


Nancy Piedra <nancy.piedra at nokia.com> has asked  for review:
Bug 58188: [Qt] MediaPlayerPrivateQt::supportsType does not parse codec
parameter
https://bugs.webkit.org/show_bug.cgi?id=58188

Attachment 89030: Modified patch based on Benjamin's comments
https://bugs.webkit.org/attachment.cgi?id=89030&action=review

------- Additional Comments from Nancy Piedra <nancy.piedra at nokia.com>
I modified the patch based on Benjamin's comments.

I believe I addressed all comments except:

1.  Why do you need to copy the string?  I needed to created a QString from a
String so that I could use the "split" function.

2.  Coding style.  I ran the "check-webkit-style" script and saw no style
errors.  If you could be more specific I will fix it.


More information about the webkit-reviews mailing list