[webkit-reviews] review requested: [Bug 58143] PerformanceTiming returns inconsistent values when timing is null. : [Attachment 88876] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has asked  for review:
Bug 58143: PerformanceTiming returns inconsistent values when timing is null.
https://bugs.webkit.org/show_bug.cgi?id=58143

Attachment 88876: Patch
https://bugs.webkit.org/attachment.cgi?id=88876&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=88876&action=review

>> Source/WebCore/page/PerformanceTiming.cpp:264
>> +	    return requestStart();
> 
> You probably should do the same for the secureConnection timers above and for
the responseEnd below.

secureConnection: "If this attribute is available but HTTPS is not used, this
attribute must return zero.", so zero is correct.
respondEnd is filled from documentLoadTiming, not resourceLoadTiming, so its
value is correct as well.