[webkit-reviews] review granted: [Bug 56930] [GStreamer] RTSP playback broken : [Attachment 88987] proposed patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 56930: [GStreamer] RTSP playback broken
https://bugs.webkit.org/show_bug.cgi?id=56930

Attachment 88987: proposed patch
https://bugs.webkit.org/attachment.cgi?id=88987&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=88987&action=review

Thanks for fixing this up!

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:49
>  gboolean mediaPlayerPrivateMessageCallback(GstBus* bus, GstMessage* message,
gpointer data);
> -void mediaPlayerPrivateVolumeChangedCallback(GObject* element, GParamSpec*
pspec, gpointer data);
> -void mediaPlayerPrivateMuteChangedCallback(GObject* element, GParamSpec*
pspec, gpointer data);
>  void mediaPlayerPrivateSourceChangedCallback(GObject* element, GParamSpec*
pspec, gpointer data);

It'd be great to remove to remov the remaining two callback in a followup
patch. :)