[webkit-reviews] review granted: [Bug 58223] [GTK] Enable building GTK port with ENABLE_PLUGIN_PROCESS=1 : [Attachment 88982] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 11 09:09:10 PDT 2011

Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 58223: [GTK] Enable building GTK port with ENABLE_PLUGIN_PROCESS=1

Attachment 88982: Patch

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=88982&action=review

Nice. Not sure why the Qt build is broken with this patch, but double-check
that it's unrelated before landing.

>> Source/WebKit2/PluginProcess/gtk/PluginProcessMainGtk.cpp:35
>> +#include <WebCore/ResourceHandle.h>
> Alphabetical sorting problem.  [build/include_order] [4]

Please fix this one before landing.

More information about the webkit-reviews mailing list