[webkit-reviews] review granted: [Bug 57827] IndexedDB: Introduce skeleton for LevelDB backend : [Attachment 88991] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 11 07:19:41 PDT 2011

Steve Block <steveblock at google.com> has granted Hans Wennborg
<hans at chromium.org>'s request for review:
Bug 57827: IndexedDB: Introduce skeleton for LevelDB backend

Attachment 88991: Patch

------- Additional Comments from Steve Block <steveblock at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=88991&action=review

Please file a bug to track looking into the use of RuntimeEnabledFeatures for
the backend type, to avoid passing the type param right through the call stack.

> Source/WebCore/storage/IDBBackingStore.h:61
> +    virtual PassRefPtr<ObjectStoreRecordIdentifier>
invalidRecordIdentifier() = 0;

I think this method should probably be named 'createInvalidRecordIdentifier'

More information about the webkit-reviews mailing list