[webkit-reviews] review denied: [Bug 58188] [Qt] MediaPlayerPrivateQt::supportsType does not parse codec parameter : [Attachment 88930] Patch to parse codec string

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Nancy Piedra
<nancy.piedra at nokia.com>'s request for review:
Bug 58188: [Qt] MediaPlayerPrivateQt::supportsType does not parse codec
parameter
https://bugs.webkit.org/show_bug.cgi?id=58188

Attachment 88930: Patch to parse codec string
https://bugs.webkit.org/attachment.cgi?id=88930&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=88930&action=review

Review express ...

> Source/WebCore/platform/graphics/qt/MediaPlayerPrivateQt.cpp:87
> +    // Parse and trim codecs

Missing dot.

> Source/WebCore/platform/graphics/qt/MediaPlayerPrivateQt.cpp:89
> +    QString codecStr = codec;

Why do you need to copy the string?

> Source/WebCore/platform/graphics/qt/MediaPlayerPrivateQt.cpp:90
> +    codecList = codecStr.split(QLatin1String(","), QString::SkipEmptyParts);


That should be a QLatin1Char(',').

Why do you create the empty QStringList just to assign it another value 2 lines
later?

> Source/WebCore/platform/graphics/qt/MediaPlayerPrivateQt.cpp:92
> +    foreach (const QString &codecStrNotTrimmed, codecList) {

Coding style.