[webkit-reviews] review denied: [Bug 58173] [qt] embed checksums in PNGs written by DRT QT : [Attachment 88895] fix license

[bugzilla-daemon at webkit.org]

Csaba Osztrogonac <ossy at webkit.org> has denied Tony Chang <tony at chromium.org>'s
request for review:
Bug 58173: [qt] embed checksums in PNGs written by DRT QT
https://bugs.webkit.org/show_bug.cgi?id=58173

Attachment 88895: fix license
https://bugs.webkit.org/attachment.cgi?id=88895&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=88895&action=review

Unfortunately DRT crashes sometimes with this patch.
r- now due to crashes. I will check it, and try to help fixing it.

>> Tools/DumpRenderTree/qt/DumpRenderTree.pro:32
>> +	../CyclicRedundancyCheck.h \
> 
> Does the .pro normally use ../ relative paths?

It works, but we usually add the directory to INCLUDEPATH instead of using
relative header paths.