[webkit-reviews] review granted: [Bug 34231] XPathResult should keep its node set's JS wrappers alive : [Attachment 88936] Same as previously with testing for the iterator type

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 34231: XPathResult should keep its node set's JS wrappers alive
https://bugs.webkit.org/show_bug.cgi?id=34231

Attachment 88936: Same as previously with testing for the iterator type
https://bugs.webkit.org/attachment.cgi?id=88936&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=88936&action=review

r=me. You may need to land this manually, since commit queue usually fails on
changes to vcproj files. But we'll see.

> LayoutTests/ChangeLog:12
> +	   Test that an event listener registered on an XPATH result snapshots'
node does
> +	   not crash. This case was already fixed prior to this change. However
it is better
> +	   to keep it as a regression test.

Since I'm still seeing this test crashing with an assertion test, I'm not a fan
of this comment.

> LayoutTests/ChangeLog:16
> +	   Test that an XPATH snapshot result keeps its node wrapper alive.

XPath.

> LayoutTests/ChangeLog:20
> +	   Test that an XPATH iterator result keeps its node wrapper alive.

XPath.

> LayoutTests/ChangeLog:24
> +	   Test that other XPATH result that holds nodes keeps their wrapper
alive.

XPath.