[webkit-reviews] review granted: [Bug 58196] new-run-webkit-tests: add unit tests for Port.diff_image() : [Attachment 88942] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Apr 10 02:01:56 PDT 2011
Ojan Vafai <ojan at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 58196: new-run-webkit-tests: add unit tests for Port.diff_image()
https://bugs.webkit.org/show_bug.cgi?id=58196
Attachment 88942: Patch
https://bugs.webkit.org/attachment.cgi?id=88942&action=review
------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=88942&action=review
> Tools/Scripts/webkitpy/layout_tests/port/chromium_unittest.py:123
> + # Routine is not implemented.
this comment here and below doesn't actually communicate anything more to me
that the code.
> Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py:135
> + if not port:
> + return
i don't get when we would ever return a null port given that this is a
unittest. but i see that the other tests all do this, so i won't block this
patch on that.
More information about the webkit-reviews
mailing list