[webkit-reviews] review granted: [Bug 53625] svn-apply and/or patch(1) has trouble applying patches that makes changes to files with Windows line endings : [Attachment 88947] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted David Levin <levin at chromium.org>'s
request for review:
Bug 53625: svn-apply and/or patch(1) has trouble applying patches that makes
changes to files with Windows line endings
https://bugs.webkit.org/show_bug.cgi?id=53625

Attachment 88947: Patch
https://bugs.webkit.org/attachment.cgi?id=88947&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=88947&action=review

This patch is OK. That being said, we will also need to update svn-unapply and,
if possible, add unit tests for this change. Towards this, we should look to
extract the file EOL logic into a function in VCSUtils.pm so that it can be
shared by both svn-apply/unapply.

I suggest that we add a FIXME comment above your change to indicate that we
should add similar functionality to svn-unapply and/or extract some of this
code and move it to VCSUtils.pm.

> Tools/Scripts/svn-apply:339
> +		   # Think of it as escaping. Patch will convert \r\n to \n, so
\r\r\n becomes \r\n.

Nit: Patch => Patch(1)