[webkit-reviews] review granted: [Bug 53625] svn-apply and/or patch(1) has trouble applying patches that makes changes to files with Windows line endings : [Attachment 88946] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 9 22:40:25 PDT 2011


Adam Barth <abarth at webkit.org> has granted David Levin <levin at chromium.org>'s
request for review:
Bug 53625: svn-apply and/or patch(1) has trouble applying patches that makes
changes to files with Windows line endings
https://bugs.webkit.org/show_bug.cgi?id=53625

Attachment 88946: Patch
https://bugs.webkit.org/attachment.cgi?id=88946&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=88946&action=review

That's horrible, but also amazing.

> Tools/Scripts/svn-apply:335
> +	       if (basename($fullPath) =~ "\.vcproj\$" || basename($fullPath)
=~ "\.vsprops\$") {

I think there's some sneaky way of writing regular expressions in perl that
avoids the need to \ the $.


More information about the webkit-reviews mailing list