[webkit-reviews] review granted: [Bug 58197] new-run-webkit-tests: fix crash when running under windows cmd.exe : [Attachment 88943] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has granted Dirk Pranke
<dpranke at chromium.org>'s request for review:
Bug 58197: new-run-webkit-tests: fix crash when running under windows cmd.exe
https://bugs.webkit.org/show_bug.cgi?id=58197

Attachment 88943: Patch
https://bugs.webkit.org/attachment.cgi?id=88943&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=88943&action=review

> Tools/Scripts/webkitpy/layout_tests/port/http_server.py:217
> +	   self._process = subprocess.Popen(start_cmd, env=env,
stdin=subprocess.PIPE)

Would it be better to use devnull?