[webkit-reviews] review requested: [Bug 57459] REGRESSION(r82419): extra border in t0805-c5519-ibrdr-r-00-a.html : [Attachment 88938] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 9 18:08:08 PDT 2011

Yael <yael.aharon at nokia.com> has asked	for review:
Bug 57459: REGRESSION(r82419): extra border in t0805-c5519-ibrdr-r-00-a.html

Attachment 88938: Patch.

------- Additional Comments from Yael <yael.aharon at nokia.com>
Slightly change the way we decide if a InlineFlowBox is the last box for its
We include the border in that box under these conditions:
(1) The next line was not created, or it is constructed. We check the previous
line for rtl.
(2) The logicallyLastRun is not a descendant of this renderer.
(3) The logicallyLastRun is a descendant of this renderer, but it is the last
child of this renderer and it does not wrap to the next line.
I added the tests from bug 47210, because now the draw the borders correctly.

More cleanup patches will follow.

More information about the webkit-reviews mailing list