[webkit-reviews] review granted: [Bug 58115] Gather data on modal dialogs shown during unload events : [Attachment 88921] Added detailed ChangeLog notes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 9 00:06:14 PDT 2011

Ryosuke Niwa <rniwa at webkit.org> has granted Sreeram Ramachandran
<sreeram at google.com>'s request for review:
Bug 58115: Gather data on modal dialogs shown during unload events

Attachment 88921: Added detailed ChangeLog notes

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=88921&action=review

> Source/WebCore/page/Chrome.cpp:287
> +static inline bool isDuringPageDismissal(const Frame* frame)
> +{
> +    return frame->loader()->pageDismissalEventBeingDispatched();
> +}
> +

I don't think you extract this as a function.

> Source/WebKit/chromium/ChangeLog:10
> +	   dispatched during unload events. Count the notifications through a
> +	   histogram.

I don't think you need to cut off a sentence awkwardly like this since WebKit
doesn't have any line limits.  You can put histogram in the previous line.

> Source/WebKit/chromium/ChangeLog:13
> +	   No tests because it's not clear how to test chromium histograms from

> +	   webkit.


More information about the webkit-reviews mailing list