[webkit-reviews] review granted: [Bug 58175] WebKit2: Safari doesn't respect cmd-arrows (and variations) as custom keyboard shortcuts : [Attachment 88898] proposed fix

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 58175: WebKit2: Safari doesn't respect cmd-arrows (and variations) as
custom keyboard shortcuts
https://bugs.webkit.org/show_bug.cgi?id=58175

Attachment 88898: proposed fix
https://bugs.webkit.org/attachment.cgi?id=88898&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=88898&action=review

> Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:545
> +    if (selector == "moveUp:")

I’d prefer if this was handled with some sort of hash table. I really wish
there was a way to leverage the editor command machinery for this.