[webkit-reviews] review granted: [Bug 58169] Make the drag operations be different functions : [Attachment 88889] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 58169: Make the drag operations be different functions
https://bugs.webkit.org/show_bug.cgi?id=58169

Attachment 88889: Patch
https://bugs.webkit.org/attachment.cgi?id=88889&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=88889&action=review

> Source/WebKit2/UIProcess/WebPageProxy.h:699
> +    void performDragControllerAction(DragControllerAction,
WebCore::DragData*, const String& = String());

I guess this doesn't need a default value anymore.

It would be nice to name the last parameter in this function and the new ones
you added. The signature is a bit mysterious without it.