[webkit-reviews] review granted: [Bug 58168] Parse 'DispatchOnConnectionQueue' in messages.in files : [Attachment 88884] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 58168: Parse 'DispatchOnConnectionQueue' in messages.in files
https://bugs.webkit.org/show_bug.cgi?id=58168

Attachment 88884: Patch
https://bugs.webkit.org/attachment.cgi?id=88884&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=88884&action=review

> Source/WebKit2/Scripts/webkit2/messages.py:84
> -	       match =
re.search(r'([A-Za-z_0-9]+)\((.*?)\)(?:(?:\s+->\s+)\((.*?)\)(?:\s+(delayed))?)?
', line)
> +	       match =
re.search(r'([A-Za-z_0-9]+)\((.*?)\)(?:(?:\s+->\s+)\((.*?)\)(?:\s+(.*))?)?',
line)

I think you could simplify this:

(?:\s+(.*))?

to this:

(.*)

> Source/WebKit2/Scripts/webkit2/messages_unittest.py:69
> -    GetPlugins(bool refresh) -> (Vector<WebCore::PluginInfo> plugins)
> -    GetPluginProcessConnection(WTF::String pluginPath) ->
(CoreIPC::Connection::Handle connectionHandle) delayed
> +    GetPlugins(bool refresh) -> (Vector<WebCore::PluginInfo> plugins)
DispatchOnConnectionQueue
> +    GetPluginProcessConnection(WTF::String pluginPath) ->
(CoreIPC::Connection::Handle connectionHandle) Delayed

Would be good to add a test that has more than one attribute.