[webkit-reviews] review denied: [Bug 56493] Drag-scrolling overlay scrollbars thumb in overflow regions does not work : [Attachment 88847] Patch for transformed and/or positioned overflow areas

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 8 11:51:17 PDT 2011


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Beth Dakin
<bdakin at apple.com>'s request for review:
Bug 56493: Drag-scrolling overlay scrollbars thumb in overflow regions does not
work
https://bugs.webkit.org/show_bug.cgi?id=56493

Attachment 88847: Patch for transformed and/or positioned overflow areas
https://bugs.webkit.org/attachment.cgi?id=88847&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=88847&action=review

> Source/WebCore/rendering/RenderLayer.cpp:2350
> +    // The clip rects need to be recomputed for painting not to include
scrollbar size for overlay scrollbars.
> +    if (ScrollbarTheme::nativeTheme()->usesOverlayScrollbars())
> +	   clearClipRectsIncludingDescendants();

Why can't you just set the flag to use temporary clip rects? We really don't
want to kill the clip rects cache altogether.

> Source/WebCore/rendering/RenderLayer.cpp:3217
> +void RenderLayer::updateClipRects(const RenderLayer* rootLayer,
OverlayScrollbarSizeRelevancy relevancy)

I don't get the "relevancy" terminology. Can't this just be an
'IncludeScrollbars enum?


More information about the webkit-reviews mailing list