[webkit-reviews] review denied: [Bug 58076] [Qt] Regression : r83051 Oxygen's lineedits are not rendered properly : [Attachment 88804] Proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 8 11:03:00 PDT 2011


Andreas Kling <kling at webkit.org> has denied Alexis Menard
<alexis.menard at openbossa.org>'s request for review:
Bug 58076: [Qt] Regression : r83051 Oxygen's lineedits are not rendered
properly
https://bugs.webkit.org/show_bug.cgi?id=58076

Attachment 88804: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=88804&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=88804&action=review

> Source/WebCore/platform/qt/RenderThemeQt.cpp:676
> -    if (isPressed(o))
> -	   panel.state |= QStyle::State_Sunken;
> +    panel.state |= QStyle::State_Sunken;

Diego is right, this needs to go in an #if USE(QT_MOBILE_THEME) block ;(


More information about the webkit-reviews mailing list