[webkit-reviews] review granted: [Bug 57743] REGRESSION(r81887): Crash in SplitElement : [Attachment 88833] fixes the bug

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 8 09:59:44 PDT 2011

Tony Chang <tony at chromium.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 57743: REGRESSION(r81887): Crash in SplitElement

Attachment 88833: fixes the bug

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=88833&action=review

> Source/WebCore/editing/CompositeEditCommand.cpp:1220
>  PassRefPtr<Node> CompositeEditCommand::splitTreeToNode(Node* start, Node*
end, bool splitAncestor)

Nit: Can we rename splitAncestor to shouldSplitAncestor?

> LayoutTests/editing/inserting/insert-images-in-pre-x-crash.html:1
> +<pre id="x"><x style="white-space: pre-wrap;"><br></x></pre>

Did you mean to include <html> and <body> here?  Maybe a doctype too.

More information about the webkit-reviews mailing list