[webkit-reviews] review granted: [Bug 58117] Incoming source should be preload scanned when the parser is blocked : [Attachment 88781] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 8 09:04:05 PDT 2011


Tony Gentilcore <tonyg at chromium.org> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 58117: Incoming source should be preload scanned when the parser is blocked
https://bugs.webkit.org/show_bug.cgi?id=58117

Attachment 88781: patch
https://bugs.webkit.org/attachment.cgi?id=88781&action=review

------- Additional Comments from Tony Gentilcore <tonyg at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=88781&action=review

This looks good, but we are starting to get a lot of entry points for scanning.
I'm wondering if we shouldn't fix bug 57376, then always kick off the preload
scanner first thing in insert() and append() (and nowhere else).

> LayoutTests/http/tests/resources/slow-script.pl:1
> +#!/usr/bin/perl -w

Is it possible to avoid adding a new resource and instead reuse
misc/resources/script-slow1.pl?


More information about the webkit-reviews mailing list