[webkit-reviews] review granted: [Bug 58040] [GTK] Unskip accessibility/input-slider.html and accessibility/media-element.html : [Attachment 88627] Patch proposal + unskipped layout tests

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has granted Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 58040: [GTK] Unskip accessibility/input-slider.html and
accessibility/media-element.html
https://bugs.webkit.org/show_bug.cgi?id=58040

Attachment 88627: Patch proposal + unskipped layout tests
https://bugs.webkit.org/attachment.cgi?id=88627&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=88627&action=review

r=me. I suspect you'd rather call accessibilityIsIgnored() than
accessibilityPlatformIncludesObject() which i think should really only be
called by accessibilityIsIgnored() itself

> Source/WebCore/accessibility/AccessibilitySlider.cpp:99
> +    if (thumb->accessibilityPlatformIncludesObject() == IgnoreObject)

can you just ask accessibilityIsIgnored() here.