[webkit-reviews] review granted: [Bug 58118] Web Inspector: use "locations" for debugger scripts, "lineNumbers" for the UI elements. : [Attachment 88802] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 58118: Web Inspector: use "locations" for debugger scripts, "lineNumbers"
for the UI elements.
https://bugs.webkit.org/show_bug.cgi?id=58118

Attachment 88802: Patch
https://bugs.webkit.org/attachment.cgi?id=88802&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=88802&action=review

> Source/WebCore/inspector/InspectorDebuggerAgent.cpp:182
> +	   // FIXME: replace with input validation.

Please file a bug and put its number next to the FIXME

> Source/WebCore/inspector/InspectorDebuggerAgent.cpp:225
> +    if (!location->getString("sourceID", &sourceId) ||
!location->getNumber("lineNumber", &lineNumber)) {

This code repeats twice, consider extracting a method.