[webkit-reviews] review granted: [Bug 58074] dump-as-markup conversion: editing/pasteboard/5065605.html and display-block-on-spans.html : [Attachment 88693] 58074

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 58074: dump-as-markup conversion: editing/pasteboard/5065605.html and
display-block-on-spans.html
https://bugs.webkit.org/show_bug.cgi?id=58074

Attachment 88693: 58074
https://bugs.webkit.org/attachment.cgi?id=88693&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=88693&action=review

> LayoutTests/editing/pasteboard/display-block-on-spans-expected.txt:4
> +The following two results must be visually identical.

Might want to note that they are identical except for the caret.

> LayoutTests/editing/pasteboard/display-block-on-spans-expected.txt:34
> +|	 "This<#selection-caret>"
> +|   <b>
> +|	 "Â is another paragraph."

FWIW, it's not as easy to tell that this is visually the same.	In particular,
the  is confusing.