[webkit-reviews] review granted: [Bug 58086] Add stub support for generating Gtk build system from gyp : [Attachment 88708] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 7 15:08:30 PDT 2011


Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 58086: Add stub support for generating Gtk build system from gyp
https://bugs.webkit.org/show_bug.cgi?id=58086

Attachment 88708: Patch
https://bugs.webkit.org/attachment.cgi?id=88708&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=88708&action=review

> Source/JavaScriptCore/gyp/gtk.gyp:11
> +  'variables': {
> +    'javascriptcore_include_dirs': [
> +	 '<(project_dir)',
> +	 '<(project_dir)/icu',
> +    ],
> +  },

I'd skip this part.  This isn't correct because Gtk doesn't have header maps.


More information about the webkit-reviews mailing list