[webkit-reviews] review granted: [Bug 57871] update DRT to embed checksums in png files : [Attachment 88698] update changelog
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Apr 7 15:02:52 PDT 2011
Eric Seidel <eric at webkit.org> has granted Tony Chang <tony at chromium.org>'s
request for review:
Bug 57871: update DRT to embed checksums in png files
https://bugs.webkit.org/show_bug.cgi?id=57871
Attachment 88698: update changelog
https://bugs.webkit.org/attachment.cgi?id=88698&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=88698&action=review
Looks great. I'm glad you don't mind iterating. :) This looks much better
than the first version to me.
> Tools/DumpRenderTree/PixelDumpSupport.cpp:91
> + static const size_t prefixLength = sizeof(textCommentPrefix) - 1;
I would comment that the -1 is for the null.
More information about the webkit-reviews
mailing list