[webkit-reviews] review requested: [Bug 57472] [Qt]REGRESSION(r82243): fast/events/onsearch-enter.html fails : [Attachment 88701] first try

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 7 14:36:47 PDT 2011


yi shen <yi.4.shen at nokia.com> has asked  for review:
Bug 57472: [Qt]REGRESSION(r82243): fast/events/onsearch-enter.html fails
https://bugs.webkit.org/show_bug.cgi?id=57472

Attachment 88701: first try
https://bugs.webkit.org/attachment.cgi?id=88701&action=review

------- Additional Comments from yi shen <yi.4.shen at nokia.com>
The problem is that EditorClientQt::handleInputMethodKeydown() is invoked by
both keydown event and keypress event, and inserts two new lines (and sends
onsearch events twice in this bug). One simple solution is by checking
defaultPrevented() for each event before trigger the insertnewline action.


More information about the webkit-reviews mailing list