[webkit-reviews] review granted: [Bug 47009] WebKit2 needs to call NPP_SetWindow when destroying a plugin : [Attachment 88697] Pass NPP_SetWindow a null window handle during plugin destruction on non-Mac platforms

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Adam Roben (:aroben)
<aroben at apple.com>'s request for review:
Bug 47009: WebKit2 needs to call NPP_SetWindow when destroying a plugin
https://bugs.webkit.org/show_bug.cgi?id=47009

Attachment 88697: Pass NPP_SetWindow a null window handle during plugin
destruction on non-Mac platforms
https://bugs.webkit.org/attachment.cgi?id=88697&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=88697&action=review

> Tools/DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:93
> +void pluginLog(NPP instance, const char* format, ...)

It would be nice to make this a member function of PluginTest.

> Tools/DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:172
> +void PluginTest::log(const char* format, ...)

Oh, never mind! :)