[webkit-reviews] review granted: [Bug 58070] HTMLVideoElement::webkitEnterFullscreen does not use new Full Screen API when available. : [Attachment 88681] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 58070: HTMLVideoElement::webkitEnterFullscreen does not use new Full Screen
API when available.
https://bugs.webkit.org/show_bug.cgi?id=58070

Attachment 88681: Patch
https://bugs.webkit.org/attachment.cgi?id=88681&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=88681&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:2464
> +#if ENABLE(FULLSCREEN_API)
> +    if (document()->settings() &&
document()->settings()->fullScreenEnabled()) {
> +	   webkitRequestFullScreen(0);
> +	   return;
> +    }
> +#else
>      ASSERT(!m_isFullscreen);
>      m_isFullscreen = true;
>      if (document() && document()->page()) {
> +
>	  
document()->page()->chrome()->client()->enterFullscreenForNode(this);
>	   scheduleEvent(eventNames().webkitbeginfullscreenEvent);
>      }
> +#endif

There isn't any need for the #else ... #endif, we want to continue to support
the old API even when ENABLE_FULLSCREEN_API is defined.

> Source/WebCore/html/HTMLMediaElement.cpp:2475
> +#if ENABLE(FULLSCREEN_API)
> +    if (document()->settings() &&
document()->settings()->fullScreenEnabled()) {
> +	   document()->webkitCancelFullScreen();
> +	   return;
> +    }
> +#else

Same here.